feat: allow granular selection of GitHub notification method via destination

argoproj / notifications-engine

Affordable notifications for Kubernetes

Apache License 2.0

264 stars 134 forks source link

Open tonglil opened 3 weeks ago

tonglil commented 3 weeks ago

Right now if someone has all of the GH notification types configured, subscribing to it will update all of them without a way to choose which one.

This is useful when you want to use commit status for one type of trigger, and deployments for another.

The change retains the existing behavior: if no recipient is specified in the subscription annotation, all notification types will be updated.

tonglil commented 2 weeks ago

Ping @pasha-codefresh or any other owner?

pasha-codefresh commented 2 weeks ago

Will review. Sorry for delay