search

argoproj / notifications-engine

Affordable notifications for Kubernetes
Apache License 2.0
264 stars 134 forks source link

Update Github integration instructions #306

Open Amphaal opened 2 weeks ago

Amphaal commented 2 weeks ago

following up https://github.com/argoproj/argo-cd/pull/18546#issuecomment-2172723055 instructions

pasha-codefresh commented 2 weeks ago

@Amphaal please fix DCO check

pasha-codefresh commented 2 weeks ago

@CodiumAI-Agent /review

CodiumAI-Agent commented 2 weeks ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5] 3
🏅 Score 85
🧪 Relevant tests No
🔒 Security concerns No
⚡ Key issues to review Possible Bug:
Ensure that the placeholders like , , and are meant to be replaced by the user or should be dynamically populated. If not handled properly, it could lead to configuration errors.
Consistency Issue:
The use of {{.context.argocdUrl}} in the new templates should be verified to ensure that it is correctly defined and accessible in all contexts where these templates are used.
Documentation:
It would be beneficial to include more detailed comments or documentation within the PR to explain the purpose and usage of the newly added templates, especially for users who might not be familiar with the specific configurations.