argos-ci / argos-cli

Argos command line interface.
https://www.argos-ci.com
MIT License
12 stars 4 forks source link

fix:add glob to dependencies #16

Closed bokuweb closed 7 years ago

bokuweb commented 7 years ago

Hi! I try using argos-cli on my repo. But, the following error occurred on travisCI.

$ ARGOS_COMMIT=$TRAVIS_COMMIT ARGOS_BRANCH=$TRAVIS_BRANCH argos upload screenshots --token $ARGOS_TOKEN || true
module.js:487
    throw err;
    ^
Error: Cannot find module 'glob'
    at Function.Module._resolveFilename (module.js:485:15)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/travis/.nvm/versions/node/v8.1.3/lib/node_modules/argos-cli/node_modules/glob-

I think that you need to add glob to dependencies, because glob is configured as peerDependencies on glob-promisepackage.

https://github.com/ahmadnassri/glob-promise/blob/master/package.json#L38

The error was solved by temporarily executing npm i -g glob.

oliviertassinari commented 7 years ago

@bokuweb Thanks

oliviertassinari commented 7 years ago

I have released a v0.0.9 version with that fix.