argos-ci / argos-cli

Argos command line interface.
https://www.argos-ci.com
MIT License
12 stars 4 forks source link

Add a `compareCommit` param when creating build #36

Open xavier-villelegier opened 3 years ago

xavier-villelegier commented 3 years ago

Hey !

We'd like to compare to the merge-base instead of the baselineBranch, to avoid having argos screenshots diffs that don't belong to your PR but were merged in the baselineBranch the meantime.

As the Github API doesn't provide a way to get the merge-base (issue opened on the github community here) we can't do this directly in argos using Octokit, so we need to find a way to send it as a param to argos.

I think this might be the optimal way as it also allows to compare to basically anything if needed