fix: don't modify IFRAME to avoid reloads

andrzej-woof commented 3 weeks ago

Description

Altering IFRAME element causes playwright to re-render contents while taking screenshot which may result in unstable screenshots.

Type of changes

bug

Checklist

Valid all before asking for a code review to argos-ci/code :

[ ] I have read the CONTRIBUTING doc - I believe the doc is not present in this repo ;)
[ ] The commits message follows the Conventional Commits' policy
[ ] Lint and unit tests pass locally
[ ] I have added tests if needed

Optional checks:

[ ] My changes requires a change to the documentation
[ ] I have updated the documentation accordingly

Further comments

Optional : Feel free to explain your motivation, share useful information or a feature screenshot.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
argos-js-sdk-reference	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 12, 2024 1:17pm

gregberge commented 3 weeks ago

@andrzej-woof could you please fix format? I can't push on your branch for a reason I ignore.

andrzej-woof commented 3 weeks ago

@gregberge should be fixed now sorry, I was doing the change via github web editor and I had actions disabled in my fork so it did not complain about format :/

gregberge commented 3 weeks ago

Thanks @andrzej-woof!

gregberge commented 3 weeks ago

I published a new release.

argos-ci / argos-javascript