argos-ci / argos

Visual Testing for modern web apps. Review visual changes in your development workflow.
https://argos-ci.com
MIT License
399 stars 33 forks source link

Duplicate Build entries in Builds tab #1312

Closed m-Pawlowicz closed 4 months ago

m-Pawlowicz commented 4 months ago

Hi, I've experienced that the exact same commit triggers an argos build twice. The duplicate one results in no screenshots.

image

As you can see there are four entries with two duplicates. Each original - duplicate entry references the same commit SHA.

This is my github action config file

name: Cypress

on:
  pull_request:
    branches:
      - main
  push:
    branches:
      - main

jobs:
  cypress:
    runs-on: ubuntu-latest
    environment: production
    env:
      CONTENTFUL_SPACE_ID: ${{ secrets.CONTENTFUL_SPACE_ID }}
      CONTENTFUL_DELIVERY_TOKEN: ${{ secrets.CONTENTFUL_DELIVERY_TOKEN }}
      CONTENTFUL_PREVIEW_TOKEN: ${{ secrets.CONTENTFUL_PREVIEW_TOKEN }}

    steps:
      - name: "list env"
        run: env

      - name: Check out repository code
        uses: actions/checkout@v3

      - name: Use Node.js
        uses: actions/setup-node@v3
        with:
          node-version: current

      - name: enable corepack
        run: corepack enable

      - name: install yarn
        run: "corepack prepare yarn@3.8.2 --activate"

      - name: Install dependencies
        run: yarn install --immutable

      - name: Cypress run
        uses: cypress-io/github-action@v6
        with:
          build: yarn build
          start: yarn start
          browser: chrome

      - name: Upload screenshots to argos-ci.com
        run: yarn run argos upload ./screenshots
        env:
          ARGOS_TOKEN: ${{ secrets.ARGOS_TOKEN }}

Question

Am i missing something? Any help would be appreciated.

Ps. I am enjoying argos so far, though some parts of the docs are a bit vague, happy to raise a pr whenever i'll have some time

m-Pawlowicz commented 4 months ago

my project id seems to be 20467

gregberge commented 4 months ago

I think you setup it twice. Once in Cypress config and once with the CLI.

Remove the Argos CLI upload and it should be OK.

m-Pawlowicz commented 4 months ago

Yes you are right 💯 Appreciate the swift response, have a great day