argos-ci / argos

Visual Testing for modern web apps. Review visual changes in your development workflow.
https://argos-ci.com
MIT License
399 stars 33 forks source link

Playwright -- Error: Request body validation failed: data/screenshots/0/metadata must NOT have additional properties #1345

Closed videate-josh closed 3 months ago

videate-josh commented 3 months ago

As a user,

When I take a screenshot via Playwright and CI, I'm not expecting the following

Error: Request body validation failed: data/screenshots/0/metadata must NOT have additional properties

Motivation

Ever since we upgraded to the latest argos: "@argos-ci/playwright": "^3.4.0", we've seen occasional failures in CI

Detail

We are using a shared method to take screenshots like this:

(in the playwright test)
     await VideateEnv.screenshot(page, 'Snapshot All Personas');

(in the shared lib)
static async screenshot(page: Page, screenshotName: string) {
       ....
      await argosScreenshot(page, screenshotName, {
        argosCSS: `iframe#launcher { display: none; }`,
      });
}    
gregberge commented 3 months ago

@videate-josh I made a temporary fix to unblock you. I will investigate in detail what is the root cause of this. In the meantime it should not happen anymore.

videate-josh commented 3 months ago

Awesome - thank you @gregberge I appreciate the rapid response and turnaround. I'll keep an eye out for the release.

videate-josh commented 2 months ago

@gregberge has this been released? I never saw a package update.

gregberge commented 2 months ago

I fixed it server side. So no need to update anything on your side.