search

argosp / argos

General issues, wiki , integrations
3 stars 1 forks source link

Values from docker-compose.yml not passed #36

Open gadieid opened 1 year ago

gadieid commented 1 year ago

Values from the files docker-compose (in the argos directory) are not passed So even though the line REACT_APP_MAP_URL: "http://my-own-tile-server-ip/resat_tiles/{z}/{x}/{y}.png" appears, the file: "src/components/Maps/MapTileLayer.jsx" Doesn;t recognize it and use its default value : 'https://{s}.basemaps.cartocdn.com/rastertiles/voyager_labels_under/{z}/{x}/{y}.png';

aronStein commented 1 year ago

The variable REACT_APP_MAP_URL is not passed to code.

see: https://github.com/argosp/trialdash/blob/master/src/components/Maps/MapTileLayer.jsx#L8 and: https://github.com/argosp/argos/blob/master/docker-compose.yml#L37

The change var must be transferred to current build services in the cloud like of kubernetes.

gadieid commented 1 year ago

Yes that is what need to be fixed