Adding map_files_root as an argument of ArgoverseMap

argoverse / argoverse-api

Official GitHub repository for Argoverse dataset

https://www.argoverse.org

Other

839 stars 240 forks source link

Adding map_files_root as an argument of ArgoverseMap #198

Closed venice-liong closed 3 years ago

venice-liong commented 3 years ago

In this PR we add map_files_root in ArgoverseMap during initialization to make it flexible in accessing maps at different paths.

The default remains to be $ROOT/map_files to ensure backward compatibility.

johnwlambert commented 3 years ago

Hi @venice-liong, thanks for your PR and sorry for the slow review.

We ended up needing to make a few small changes to this PR for the CI, and to support Path instead of just str arguments, so we put them in this PR https://github.com/argoai/argoverse-api/pull/207 which was just merged. I'll go ahead and close this one, for now.

Thank you again and please let us know if you run into any issues.