Increase readability by placing global constants in a config

argoverse / argoverse-api

Official GitHub repository for Argoverse dataset

https://www.argoverse.org

Other

839 stars 240 forks source link

Increase readability by placing global constants in a config #219

Closed johnwlambert closed 3 years ago

johnwlambert commented 3 years ago

Currently, global constants like frame rate and image dimensions are scattered across the codebase, including in data_loading/synchronization_database.py and utils/camera_stats.py. This PR places them in a more intuitive place for the user -- a single config file -- increasing readability for the codebase.

The constants are available by a single import call:

from argoverse.sensor_dataset_config import ArgoverseConfig

johnwlambert commented 3 years ago

Note: structured configs w/ defaults and type validation to be considered in follow-up PR