argoverse / argoverse-api

Official GitHub repository for Argoverse dataset
https://www.argoverse.org
Other
839 stars 240 forks source link

Added pyproject.toml. #231

Closed benjaminrwilson closed 3 years ago

benjaminrwilson commented 3 years ago

Overview

This PR adds a pyproject.toml file to consolidate styling tools such as isort and black.

Each "block" within this file specifies a different type of options. For example, isort is written as:

[tool.isort]

known_first_party = "argoverse"
line_length = 120
multi_line_output = 3
profile = "black"

The options above should have a 1-to-1 correspondence with isort.cfg.

Advantages

benjaminrwilson commented 3 years ago

Removed .isort.cfg since pyproject.toml contains the configuration now.

johnwlambert commented 3 years ago

Hi Ben, does the .toml file change our pre-commit config, or our Tox configuration?

benjaminrwilson commented 3 years ago

None of that should change with this commit. pre-commit doesn't have support (although, it's widely requested) and tox is still defined in a separate file. I suggest nox support in a separate PR.

johnwlambert commented 3 years ago

isort states that .isort.cfg or pyproject.toml are both supported: https://pycqa.github.io/isort/docs/configuration/options/