search

argoverse / argoverse-api

Official GitHub repository for Argoverse dataset
https://www.argoverse.org
Other
839 stars 240 forks source link

Fix matmul bug and add __repr__ method to Sim2 #243

Closed johnwlambert closed 3 years ago

johnwlambert commented 3 years ago

Previously, the compose() method had a bug ( R1 * R2 was used instead of the correct R1 @ R2) that was not caught since the unit test used identity matrices, for which the operations are identical.

This PR also adds a repr method for helpful printing/debugging of the class representation.

benjaminrwilson commented 3 years ago

Additionally, could we add periods for the rest of the docstrings in sim2.py?

johnwlambert commented 3 years ago

No problem, just added periods to the rest of the docstrings