search

argoverse / argoverse-api

Official GitHub repository for Argoverse dataset
https://www.argoverse.org
Other
833 stars 239 forks source link

Bump hydra + omegaconf. #246

Closed benjaminrwilson closed 3 years ago

benjaminrwilson commented 3 years ago

Compatible releases of hydra and omegaconf are available.

johnwlambert commented 3 years ago

Thanks for the PR, Ben. Good we dont have to use the dev prerelease versions anymore.

My understanding is that if we don't pin down the new version number, then if someone went to install argoverse-api, and had an old version of hydra-core on their system, then those dependencies would not be updated, and could lead to missing functionality.

benjaminrwilson commented 3 years ago

In that case, do you think we should pin all of the dependencies?

johnwlambert commented 3 years ago

I think we've already pinned down the ones where we saw people having issues, or where we saw some significant changes between versions. Maybe we can just pin down hydra and omegaconf for now?

johnwlambert commented 3 years ago

LGTM