search

argoverse / argoverse-api

Official GitHub repository for Argoverse dataset
https://www.argoverse.org
Other
845 stars 241 forks source link

Motmetrics upgrade #263

Open ahuller3 opened 3 years ago

ahuller3 commented 3 years ago

Reformats data (uuids from string to int) and deals with invalid distances to make compatible with motmetrics version 1.2 which significantly improves runtime

johnwlambert commented 3 years ago

Thanks for the PR, @ahuller3. I'll take a look!

johnwlambert commented 3 years ago

Looks like there are a few type complaints by mypy:

argoverse/evaluation/eval_tracking.py:164: error: Need type annotation for "all_uuids" (hint: "all_uuids: Dict[<type>, <type>] = ...")
argoverse/evaluation/eval_tracking.py:213: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:214: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:216: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:217: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:218: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:219: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:220: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:222: error: Non-overlapping container check (element type: "int", container item type: "str")
argoverse/evaluation/eval_tracking.py:223: error: Argument 1 to "append" of "list" has incompatible type "int"; expected "str"
argoverse/evaluation/eval_tracking.py:244: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:245: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:246: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:247: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:248: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:249: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:250: error: Invalid index type "int" for "Dict[str, Dict[str, Any]]"; expected type "str"
argoverse/evaluation/eval_tracking.py:252: error: Argument 1 to "append" of "list" has incompatible type "int"; expected "str"
johnwlambert commented 3 years ago

Could you update the requirements file as well, where themotmetrics version is listed?