argoverse / av2-api

Argoverse 2: Next generation datasets for self-driving perception and forecasting.
https://argoverse.github.io/user-guide/
MIT License
306 stars 71 forks source link

make angle a named parameter for matplotlib Rectangle constructor #235

Closed viktortnk closed 6 months ago

viktortnk commented 7 months ago

PR Summary

make angle a named parameter for matplotlib Rectangle constructor

https://matplotlib.org/stable/api/_as_gen/matplotlib.patches.Rectangle.html

According to the latest documentation matplotlib's Rectangle has only 3 positional arguments (not 4 as earlier).

As the name of parameters matches, the change should be compatible with earlier version of the library

Testing

In order to ensure this PR works as intended, it is:

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

benjaminrwilson commented 6 months ago

Hi @viktortnk , thank you for the PR! Would you mind pulling in the latest changes from main so we can resolve the CI?

viktortnk commented 6 months ago

Hi @benjaminrwilson Sure, rebased. I see all checks are green now

benjaminrwilson commented 6 months ago

Great, thank you!