search

argoyle / tapestry-tagselect

Tapestry-tagselect is a select component for Tapestry 5 similar to the version selector in recent JIRA-versions.
Other
12 stars 2 forks source link

InputKeyDown InputKeyUp #7

Closed ghost closed 12 years ago

ghost commented 13 years ago

I'm noticing tapestry isn't handling InputKeyDown or InputKeyUp correctly, when I use the arrow keys, the document scrolls all over the place. Any good way to implement a fix? I opened up a thread on Nabble related to this, not sure why it doesn't work, I see the js to handle this functionality in the control.js. It also seems to be an issue with the example on JumpStart.

argoyle commented 13 years ago

Good question. I would say this is also in the Prototype/Scriptaculous-code. Without rewriting the autocompleter-stuff, I would say we are at the mercy of the standard library.

argoyle commented 13 years ago

Not sure of how it worked before but with my latest changes I see no such behavior on chromium and firefox on linux.

ghost commented 13 years ago

I'll check it out tomorrow.

On Thu, Oct 20, 2011 at 4:40 PM, Joakim Olsson < reply@reply.github.com>wrote:

Not sure of how it worked before but with my latest changes I see no such behavior on chromium and firefox on linux.

Reply to this email directly or view it on GitHub: https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-2474085

George Christman www.CarDaddy.com P.O. Box 735 Johnstown, New York

ghost commented 13 years ago

doesn't work at all now ;-) I'll look into this a little bit more when I have some additional time.

argoyle commented 13 years ago

Hmmm...And you have cleared caches etc? I have made changes to the javascript-file so you must make sure that it's using the new file of course.

ghost commented 13 years ago

I'll try again Monday, but it didn't seen to work.

-George

----- Reply message ----- From: "Joakim Olsson" reply@reply.github.com Date: Sat, Oct 22, 2011 5:25 am Subject: [tapestry-tagselect] InputKeyDown InputKeyUp (#7) To: "George Christman" gchristman@cardaddy.com

Hmmm...And you have cleared caches etc? I have made changes to the javascript-file so you must make sure that it's using the new file of course.

Reply to this email directly or view it on GitHub: https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-2489172

argoyle commented 13 years ago

Just tried it on my wifes windows-box in both Firefox and Internet Explorer and it seems to work fine here.

ghost commented 13 years ago

do you have a vertical scroll bar on your test page?

argoyle commented 13 years ago

Ooh. It was just the scrolling-part that didn't work. I thought the whole component was broken. :-)

Just tried it with a really small window with vertical scrollbar in Chromium and Firefox on linux and Safari, IE and Firefox on windows and it behaves the same in all of them.

It seems to try to keep the currently selected item on the screen and that will of course scroll the page if necessary.

It's a bit strange when you are moving down and the selected item is at the bottom of the screen and then you move up one item and the selected item is all of a sudden at the top of the window but apart from that I think it behaves as expected.

argoyle commented 13 years ago

I would say a release is close now. Any further changes you see that we need before that George?

ghost commented 13 years ago

Hi joakim, I'm not at work today, but ill test things tomorrow.

-George

----- Reply message ----- From: "Joakim Olsson" reply@reply.github.com Date: Sun, Oct 30, 2011 6:29 pm Subject: [tapestry-tagselect] InputKeyDown InputKeyUp (#7) To: "George Christman" gchristman@cardaddy.com

I would say a release is close now. Any further changes you see that we need before that George?

Reply to this email directly or view it on GitHub: https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-2571983

argoyle commented 13 years ago

Hi George, did you get any time time to test yet? Would be nice with a release soon.

ghost commented 13 years ago

Hi Joakim, I did get a chance to test and there is in fact some broken things now. I just haven't had a chance to repair them just yet. I will be getting back to it soon.

On Fri, Nov 18, 2011 at 12:19 PM, Joakim Olsson < reply@reply.github.com

wrote:

Hi George, did you get any time time to test yet? Would be nice with a release soon.

Reply to this email directly or view it on GitHub: https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-2791680

George Christman www.CarDaddy.com P.O. Box 735 Johnstown, New York

argoyle commented 13 years ago

Ok, I'll wait with the release a bit then. :-)

argoyle commented 13 years ago

George, can you describe the problems you are seeing then maybe I can manage to solve them?

ghost commented 13 years ago

Hi joakim, I actually got back to the project on Friday. Issues thus far are as followed, 1. up and down scroll of the autocomplete results using the the arrows causes the page to scroll erratically. 2 the drop down icon within the single has changed behavior since you changed the default setting. 3. Your last repair causes the autocomplete results to come and go rapidly. I'm concerned issue one is a prototype bug which we won't be able to resolve very easilly. The other two were introduced in your latest change set.

-George

----- Reply message ----- From: "Joakim Olsson" reply@reply.github.com Date: Sun, Dec 4, 2011 8:34 am Subject: [tapestry-tagselect] InputKeyDown InputKeyUp (#7) To: "George Christman" gchristman@cardaddy.com

George, can you describe the problems you are seeing then maybe I can manage to solve them?

Reply to this email directly or view it on GitHub: https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-3006480

argoyle commented 13 years ago

Great.

I've described what I think is the issue with 1 here https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-2521116 and I agree that it's probably a Prototype or browser issue rather than something that we can handle ourselves.

2) Since the dropdown was always there before I thought the most reasonable default would be to keep it that way for the next version as well.

3) I'll look into this. It might be something that need to be reset or something like that. It seems to work better if I keep the mousebutton pressed for a short while on the dropdown rather than just clicking normally.

argoyle commented 13 years ago

Ok, some more investigation regarding 3 done. The problem occurs when focus is on the actual input-field. There is an onBlur method which closes the popup after 250ms (line 190 of control.js). That explains why it seems to work if I hold the mousebutton pressed for a while (longer than 250ms I guess).

Is it possible somehow to make the dropdown not steal focus? This is really not my area of expertise. :-)

ghost commented 13 years ago

I'll take a look at it tomorrow, I'm just about to head out of the office, but not a problem. Didn't get a chance to play with it today.

On Mon, Dec 5, 2011 at 2:40 PM, Joakim Olsson < reply@reply.github.com

wrote:

Ok, some more investigation regarding 3 done. The problem occurs when focus is on the actual input-field. There is an onBlur method which closes the popup after 250ms (line 190 of control.js). That explains why it seems to work if I hold the mousebutton pressed for a while (longer than 250ms I guess).

Is it possible somehow to make the dropdown not steal focus? This is really not my area of expertise. :-)

Reply to this email directly or view it on GitHub: https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-3021962

George Christman www.CarDaddy.com P.O. Box 735 Johnstown, New York

argoyle commented 13 years ago

Great.

argoyle commented 12 years ago

Just pushed a small change to the dropdown trigger. I added a short delay before activating the autocompleter. It seems to have solved the problem as far as I can see at least. I have tried it on Chrome and Firefox on Linux and IE, Firefox and Safari on Windows.

I noticed a small IE problem with the resizing of the dropdown trigger in IE when having a multi-select field and selecting the first value. It looked like it thought the field was twice the height it was. It wasn't happening everytime though. Couldn't really see a pattern to it either.

If you have the time some day George, it would be great if you could test my fix and possibly also look at the IE-problem.

argoyle commented 12 years ago

George, have you had the time to look at my "fix" and the IE-problem yet? Would be nice to get a real release out the door soon.

ghost commented 12 years ago

Hi Joakim, I apologize for this taking so long to complete. My companies management team decided to change out our frontend js framework to utilize the Tapestry Jquery project. I do still have a copy of the project utilizing the prototype framework on my personal machine, so I'll get that tested for you one night this week. Hope you had a good xmas!

On Mon, Dec 26, 2011 at 5:12 AM, Joakim Olsson < reply@reply.github.com

wrote:

George, have you had the time to look at my "fix" and the IE-problem yet? Would be nice to get a real release out the door soon.

Reply to this email directly or view it on GitHub: https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-3273758

George Christman www.CarDaddy.com P.O. Box 735 Johnstown, New York

argoyle commented 12 years ago

No problem at all. I fully understand that other things need to be prioritized. Xmas has been good on my end, hope yours has been good as well.

Does that mean that you have a version of the project based on the tapestry-jquery project? Maybe we should add it as a separate branch or so?

ghost commented 12 years ago

I hope to build one, just haven't had the time since my priorities have been shifted in this migration.

On Tue, Dec 27, 2011 at 3:39 PM, Joakim Olsson < reply@reply.github.com

wrote:

No problem at all. I fully understand that other things need to be prioritized. Xmas has been good on my end, hope yours has been good as well.

Does that mean that you have a version of the project based on the tapestry-jquery project? Maybe we should add it as a separate branch or so?

Reply to this email directly or view it on GitHub: https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-3285026

George Christman www.CarDaddy.com P.O. Box 735 Johnstown, New York

argoyle commented 12 years ago

Sounds great. Always nice to be able to support both camps. :-)

argoyle commented 12 years ago

Have you had any time to look at the IE-problem yet George?

It would be nice to release a version for Tapestry 5.2.6 soon and then upgrade and release it for 5.3.1 as well.

argoyle commented 12 years ago

George, I think I nailed the IE-bug now. I added an extra clearfix-div inside the token container for non-vertical tagselects.

If you have the time to test it out a little bit would be great. Otherwise I think I'll release it as it is now.

I have tested it in Chrome and Firefox on Linux and Firefox, IE and Safari on Windows and it seems to behave correctly now.

ghost commented 12 years ago

Hi Joakim, I'm glad you were able to figure it out. I'm really sorry I haven't had a chance to help you out : ( I've had no extra time for any fun projects lately. Getting sick last month really put me behind on all my core projects. I've been struggling to get caught up again. I'll keep you posted when I'm all caught up.

On Fri, Feb 10, 2012 at 4:12 PM, Joakim Olsson < reply@reply.github.com

wrote:

George, I think I nailed the IE-bug now. I added an extra clearfix-div inside the token container for non-vertical tagselects.

If you have the time to test it out a little bit would be great. Otherwise I think I'll release it as it is now.

I have tested it in Chrome and Firefox on Linux and Firefox, IE and Safari on Windows and it seems to behave correctly now.

Reply to this email directly or view it on GitHub: https://github.com/argoyle/tapestry-tagselect/issues/7#issuecomment-3914365

George Christman www.CarDaddy.com P.O. Box 735 Johnstown, New York

argoyle commented 12 years ago

Definately no problem. You have helped very much. Most of the next release really apart from a couple of unit-test fixes and minor changes from me. :-)

I'll make a release of what we have during the weekend and then we can upgrade to the latest version of Tapestry and fix any bugs we find after that.