search

argtable / argtable3

A single-file, ANSI C, command-line parsing library that parses GNU-style command-line options.
http://www.argtable.org
Other
372 stars 65 forks source link

insufficient CMake minimum version #48

Closed mfernan2 closed 4 years ago

mfernan2 commented 4 years ago

Commit d1f6cdef added some CMake lines that use add_compile_definitions. This command was only added to CMake in 3.12. However, the root level CMakeLists.txt only requires 3.0 as a minimum CMake version. I think this needs to be bumped to 3.12

tomghuang commented 4 years ago

Thanks for bringing up this problem. I don't like to force developers upgrading their CMake because of this tiny patch. I will go back using the old add_definitions().