search

argtable / argtable3

A single-file, ANSI C, command-line parsing library that parses GNU-style command-line options.
http://www.argtable.org
Other
372 stars 65 forks source link

Various minor fix #59

Closed xiaoxiang781216 closed 3 years ago

xiaoxiang781216 commented 3 years ago

Please read the commit message for the more info

tomghuang commented 3 years ago

Hi @xiaoxiang781216,

Why did you remove find ../dist -name '*' | xargs dos2unix and find ../dist -name '*' | xargs unix2dos ? Is it because they will cause problems, or because they are not necessary? My intention here is to make sure that files in the tar.gz format will have UNIX newline characters and files in the zip format will have Windows newline characters. May I know your concerns here? Thanks.

xiaoxiang781216 commented 3 years ago

I want to remove dos2unix or unix2dos in dist, since the caller of dist always call dos2unix or unix2dos. But, the patch modify the wrong location, please review the update.

tomghuang commented 3 years ago

Hi @xiaoxiang781216 , I prefer keep dos2unix and unix2dos in the dist function, because many people don't use build_tar and build_zip, but only use dist to generate the amalgamation distribution. In this case, the dos2unix and unix2dos can guarantee the files have correct newline characters.

However, I will remove dos2unix in build_tar in the bash script, and remove unix2dos in build_zip in the Windows batch script. Thanks for reminding me this duplication.

I'll merge your pull request first, and then modify this patch.