argumentcomputer / bellpepper-gadgets

A library of gadgets compatible with bellpepper and bellperson (contact: @huitseeker)
Apache License 2.0
17 stars 13 forks source link

Review `bellpepper*` and `arecibo` dependencies #34

Closed tchataigner closed 9 months ago

tchataigner commented 9 months ago

In #33 I had to have the triplet bellpepper, bellpepper-core and arecibo as dependencies, and I got a bit lost in how they are managed.

Looking at a some projects having those as dependency, it seems that most of them have adopted the "fork" approach that let's us quickly pull updates (lurk-rs, circom-scotia, arecibo, ...) while others (such as this one) have opted for a fixed crate version.

I think we would probably gain to try and unify the way we import those dependencies.

As @huitseeker suggested I tried various triplets of dependencies and it seems that the one that worked for me is bellpepper = 0.4.1 bellpepper-core as fork and arecibo as fork. We could use this as a global approach.

tchataigner commented 9 months ago

Fixed with #39