Closed porcuquine closed 3 years ago
I would prefer if we chose the option not to duplicate the tests for lurk-rs.
Can you clarify what you mean? I think I've lost track of the context.
My current plan is to enable lurk-rs
to process the .lurk
test files and succeed/fail appropriately. Are you saying you agree with this plan, or something else?
Yes, that sounds good. I am referring to this comment:
The lurk-rs REPL needs to be extended to support these tests, and they should be added to the test suite there.
I just want to make sure we don't duplicate the test suite. Maybe have the convention that both of these projects are in sibling directories?
I understand what you mean now, thanks.
I wonder if the cleanest thing would be to move the tests to their own repo and make it a submodule of both lurk
and lurk-rs
.
I definitely agree that the test source files should not be duplicated.
Here is a PR to added support for this in lurk-rs
: https://github.com/lurk-lang/lurk-rs/pull/10.
I think this is the minimum viable REPL/CLI test machinery we need. It does the following:
!(:do-something …)
toplevel 'script' forms.!(:assert …)
and!(:assert-eq …)
script forms, for minimal testing.to
lurk/x`.lurk
returns non-zero exit code if there is an assertion failure.lurk
returns exit code zero if there are no errors in reading, evaluation, and no assertions fail.:load
,:assert-eq
,:assert
.example-suite
tests are added, which directly invoke the CLI on designated test examples.TODO:
:impl
tests (lang.lisp
) are disabled because of a (previously-known see #10) bug. This should be fixed, then the tests enabled.lurk-rs
REPL needs to be extended to support these tests, and they should be added to the test suite there..lurk
files should allow comments.