argumentcomputer / lurk-lisp

Lisp implementation of Lurk.
MIT License
67 stars 6 forks source link

Repl tests #13

Closed porcuquine closed 3 years ago

porcuquine commented 3 years ago

I think this is the minimum viable REPL/CLI test machinery we need. It does the following:

TODO:

porcuquine commented 3 years ago

I would prefer if we chose the option not to duplicate the tests for lurk-rs.

Can you clarify what you mean? I think I've lost track of the context.

My current plan is to enable lurk-rs to process the .lurk test files and succeed/fail appropriately. Are you saying you agree with this plan, or something else?

namin commented 3 years ago

Yes, that sounds good. I am referring to this comment:

The lurk-rs REPL needs to be extended to support these tests, and they should be added to the test suite there.

I just want to make sure we don't duplicate the test suite. Maybe have the convention that both of these projects are in sibling directories?

porcuquine commented 3 years ago

I understand what you mean now, thanks.

I wonder if the cleanest thing would be to move the tests to their own repo and make it a submodule of both lurk and lurk-rs.

I definitely agree that the test source files should not be duplicated.

porcuquine commented 3 years ago

Here is a PR to added support for this in lurk-rs: https://github.com/lurk-lang/lurk-rs/pull/10.