search

argumentcomputer / lurk-lisp

Lisp implementation of Lurk.
MIT License
67 stars 6 forks source link

Implement RAM, define, defmacro using a separate expansion #29

Closed namin closed 2 years ago

namin commented 2 years ago

The functionality is complete, so I'd like a review on that. We'll then have to figure out how to subset/version Lurk before merging this in.

You can also see in the history the implementation with interleaving expansion and evaluation.

Thanks!

namin commented 2 years ago

Hi @porcuquine -- I'd like a review on this now. I've incorporated all the feedback except for moving the examples to lurk-lib. I'll also need to rebase eventually.

Please let me know what you think.

namin commented 2 years ago

workflow: once you approve this, I'll rebase, move the examples to lurk-lib, submit a P/R on lurk-lib, get that P/R merged, and then merge here. Sounds good?

porcuquine commented 2 years ago

Workflow sounds good. Looking at the PR now.

namin commented 2 years ago

Rebased. I think I still need approval.

namin commented 2 years ago

Rebased, and final approval required. Thanks.