argumentcomputer / zk-light-clients

A collection of ZK light client libraries for various blockchains. (contact: @tchataigner)
30 stars 4 forks source link

refactor: Adapt to Sphinx (Refactor proof handling) #161

Closed huitseeker closed 2 months ago

huitseeker commented 2 months ago

Summary

This is the companion PR of https://github.com/argumentcomputer/sphinx/pull/150

In Detail

[!IMPORTANT] After https://github.com/argumentcomputer/sphinx/pull/150

[!NOTE] This is a companion PR, what you want to look at the CI result of the penultimate commit. The last commit's failure is expected.

huitseeker commented 2 months ago

Except I'm not 100% sure that the bytes() method in the fixture-generator is correct with the pr.raw_proof/pr.encoded_proof thing

True, I can revert to the encoded proof if this is needed, it's an easy fix.

wwared commented 2 months ago

@samuelburnham: We will need to update the cycle-count-regression CI check due to output format changes, see #164. It's failing for aptos in this PR and the ethereum one is currently only passing because this PR has not yet been rebased on top of #163 so it's not running any tests. This is a lower priority/non-blocking issue that we can solve later on and merge with the failing CI checks if we need to

storojs72 commented 2 months ago

I have updated Move tests, so now only cycle-count-regression stuff is broken. As we can tackle this in subsequent PRs, I think this one is good to merge once CI finishes