search

argv-minus-one / dmg-license

Generate license agreements for macOS .dmg files
MIT License
19 stars 6 forks source link

packages including dmg-license become uninstallable on linux #8

Closed airtonix closed 3 years ago

airtonix commented 3 years ago

using pnpm, any project that ends up describing your packages as a dep becomes uninstallable.

airtonix commented 3 years ago

ugh... https://github.com/pnpm/pnpm/issues/3640

zkochan commented 3 years ago

Maybe we can fix it in pnpm, I am not sure.

But the issue is that iconv-corefoundation is not an optional dependency. Even though it supports only macOS.

argv-minus-one commented 3 years ago

@zkochan Dmg-license also supports only macOS. It needs not only iconv-corefoundation but also the hdiutil program that only exists on macOS. See https://github.com/argv-minus-one/dmg-license/issues/7#issuecomment-894857493 for details.