search

argyleink / open-props

CSS custom properties to help accelerate adaptive and consistent design.
https://open-props.style
MIT License
4.78k stars 193 forks source link

issues with typings #337

Closed mayank99 closed 1 year ago

mayank99 commented 1 year ago

Found a few issues in typings when testing 1.5.4:

  1. all the primitive types are quoted, i.e. "string" and "number" instead of string and number. see open-props.d.ts.
  2. props.animations.js only contains kebab-case properties but props.animations.d.ts contains both kebab and camel case. same problem applies to all files in src/ directory
  3. props.colors.js contains individual and combined objects for colors. props.colors.d.ts only contains combined.

all of these could be fixed by using tsc instead of generating types by hand 🤔