search

argyleink / open-props

CSS custom properties to help accelerate adaptive and consistent design.
https://open-props.style
MIT License
4.76k stars 194 forks source link

"normalize dark": Conflict Between "oklch Gray" and the Classic Gray #388

Open mobalti opened 1 year ago

mobalti commented 1 year ago

The oklch gray colors override the classic gray in "normalize dark".

You can reproduce the bug by adding:

@import "https://unpkg.com/open-props/gray-oklch.min.css";

to "normalize dark".

I suggest changing the name of the oklch gray colors from "--gray-1" to "--ok-gray-1" or "--gray-1-oklch".

argyleink commented 1 year ago

i see! i figured folks would use either or but you're wanting to have both on the page? I also imagined the oklch grays would overtake the old ones as the library moved forward with HDR color, but maybe having them named a bit separate is good.

name could also be --hdr-gray-1 and stuff, to separate with even further based on it's quality and not the space?

mobalti commented 1 year ago

great news that we will move forward with HDR colors!