search

argyleink / open-props

CSS custom properties to help accelerate adaptive and consistent design.
https://open-props.style
MIT License
4.78k stars 193 forks source link

Inset shadows #393

Closed Vidhanvyrs closed 1 year ago

Vidhanvyrs commented 1 year ago

changes done on props.shadows.js according to the codepen example that was given with the issue Please provide feedback and point out if any particular changes required

stackblitz[bot] commented 1 year ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Vidhanvyrs commented 1 year ago

Thankyou @argyleink The required changes will be done in no time I'M ON IT!

Vidhanvyrs commented 1 year ago

Extremely sorry i accidently added the commit without running the npm run lib: shadows in the commit 7e9aa4c but i do performed it in commit 0d1ba17 So now i am clarifying about the changes! Please forgive 🙇‍♂️

Vidhanvyrs commented 1 year ago

yeah so @argyleink now i think the commit 157808f is correct there is no formatter disturbance in this commit and the shadow is also going well waiting for the review

argyleink commented 1 year ago

here! i wont merge this PR i'm linking because i want you to get contribution credit for all the work you've put in so far, but this is the PR shape I'm lookin for 🙂

https://github.com/argyleink/open-props/pull/399

argyleink commented 1 year ago

hi @Vidhanvyrs, you still interested in contributing this? #399 is ready to go, shows all the changes needing to be made, but I'd still totally prefer if you got credit for the work you've done so far so I don't want to merge it 🙂

Vidhanvyrs commented 1 year ago

No thankyou its fine you lot can continue BTW thanx!!🙇‍♂️