Closed kalligator closed 1 year ago
Run & review this pull request in StackBlitz Codeflow.
Thank you for filing this 🙂
I'm surprised I committed a physical property for text alignment, I assumed I would have committed text-align: start
.
What if we did this:
:where(td:not([align]), th:not([align])) {
text-align: start;
}
this way
start
is always the default alignment (wont break for right to left users) align
attribute is absent from the cell:not()
is within the :where()
as to not increase specificity and be easy to overrideThat sounds a lot better indeed!
I noticed that :where(td,th) has text-align: left set, which messes things up when td or th has align="center" in their html tag.
I fixed this issue, but I think it would be better to remove the alignment from :where(td,th) altogether, because it might also cause problems for right-to-left users.