argyleink / open-props

CSS custom properties to help accelerate adaptive and consistent design.
https://open-props.style
MIT License
4.52k stars 184 forks source link

value and type -> $value and $type causes issues in current version of figma-tokens #455

Closed hchiam closed 5 months ago

hchiam commented 6 months ago

while updating my notes and videos of setting up op in figma-tokens, i noticed tokens aren't properly generated in the latest figma-tokens plugin when i try to use either of the following URLs:

Commit https://github.com/argyleink/open-props/commit/327a70f82aa3aa6c553138ffd1572b3c4fd0ab18 was done to update design token json to the latest spec syntax, but i'm thinking we'll need to undo part of the commit to treat figma tokens differently.

it seems the figma-tokens plugin is still expecting value and type instead of $value and $type because it keeps trying to recreate value and type when i hit "Save JSON", but it does so badly:

figma-tokens tries to convert from $value to value but does it badly

and the output does not look right:

the output has $value and $type as individual values, with everything under Other