durations.css – correct leap-year duration; introduce olympiad

argyleink / open-props

CSS custom properties to help accelerate adaptive and consistent design.

https://open-props.style

MIT License

4.52k stars 184 forks source link

durations.css – correct leap-year duration; introduce olympiad #475

Closed trych closed 4 months ago

trych commented 4 months ago

Hi there,

just noted an error in the durations. A leap year does not refer to a time span of four years, but to the length of the year where the leap day occurs, i.e. 366 days.

On the other hand, conveniently, there is a duration that describes a four-year timespan, an olympiad, which I introduced as a new property.

Hope this makes sense.

stackblitz[bot] commented 4 months ago

Run & review this pull request in StackBlitz Codeflow.

argyleink commented 4 months ago

oh nice, tests are only for the main bundle, not for extra packs. this is g2g!