argynarg / DharmaProject

1 stars 0 forks source link

Send me a new invitation to join your DharmaProject repo? #2

Open ebeshero opened 3 years ago

ebeshero commented 3 years ago

@argynarg @Joelpie Apologies! You sent me an invitation to join your repo a long while ago, and it seems like I missed it or didn't respond correctly. Can you send it to me again? I have a bunch of comments I want to share with you on your XSLT file. Basically, the table output is an excellent idea, and the next step is how to represent more of your markup in the original portion of the document. So I left a bunch of ideas--a lot of them related to what HTML and CSS you can try.

Also, you need an XHTML namespace at the top and and <xsl:output> line here, so I just added them. And you're going to need to move/update some of the styling code you have in the HTML elements: align="center" isn't used anymore, and you now want the CSS property: margin:auto; just up where you're doing the CSS code.

In the meantime, there's another way: I can send my suggestions to you as a pull request, so I'll ping you here when I've done that.