search

arhs / iban.js

IBAN & BBAN validation, formatting and conversion in Javascript
https://arhs.github.io/iban.js/
MIT License
535 stars 130 forks source link

Remove the Array.prototype.map polyfill #41

Open ctavan opened 7 years ago

ctavan commented 7 years ago

I believe libraries should usually not pollute the global namespace and should therefore also not modify native prototypes.

In addition Array.prototype.map is supported in all modern browsers (even IE 9 onwards) so I believe this is safe to drop in the end of 2017.

For people who need to support even older browser there are enough transpiling solutions these days.

LaurentVB commented 7 years ago

Hi Ctavan,

Thanks for the suggestion. Perfectly right about the non-pollution thing. As reasonable as your suggestion is, it's still a breaking change for browser compatibility so it's something we should bump the major version on. I think the lib is probably due for a modern rewrite, so I'll keep this PR open as a reminder ;-)

Laurent

ctavan commented 7 years ago

@LaurentVB thanks for the feedback.

Does that mean that you're currently actively working on a rewrite? Or would you rather suggest that I start my own fork if I need a polyfill-less variant in the near future?

zyv commented 5 years ago

@LaurentVB any update on that one? More than a year later, IE8- is less relevant than ever before... Thanks!