search

arhs / iban.js

IBAN & BBAN validation, formatting and conversion in Javascript
https://arhs.github.io/iban.js/
MIT License
534 stars 128 forks source link

Are there plans to switch to ES module? #81

Open flensrocker opened 3 years ago

flensrocker commented 3 years ago

Rewriting iban.js is not that hard, but I fail to migrate the tests...

sander1095 commented 3 years ago

Hello! Any updates on this? It'd be great if this was an ES Module

flensrocker commented 3 years ago

If you can help to rewrite the test, that would be great. I don't have much experience with them...

sander1095 commented 3 years ago

I have mailed @arhs about the status of this project. I also ping @LaurentVB because they have done the latest work on this project.

If this project is unmaintained I do not see a reason to write tests; it'd be better to fork this project instead. There are a lot of important issues and PR's open and currently I am unsure if your (great!) PR will be merged.

Qsaws commented 3 years ago

Same request here, did you get a response from them @sander1095 ?

sander1095 commented 3 years ago

Nope, no response sadly

Qsaws commented 3 years ago

Nope, no response sadly

I switched to this package https://www.npmjs.com/package/ibantools

flensrocker commented 3 years ago

If someone has time to rewrite the tests, we might create a forked package. The last commit is over a year ago. I don't know if this source is maintained any more.

itoche commented 3 years ago

Hi all, I'm checking if someone at @arhs will take over the maintenance of this package. I'll let you know in the next days if we continue to maintain it or not.

itoche commented 3 years ago

Sadly, the lib will not be maintained anymore.

flensrocker commented 3 years ago

Thank you for the response.
Not supporting it anymore is ok, the source is MIT, so I can fork it and make my own module.

sander1095 commented 3 years ago

@flensrocker I would just use ibantools like @Qsaws suggested. I switched to it and works great!

sander1095 commented 3 years ago

I have created #88 and #89 to finalize the state change of this repo to "unmaintained"

flensrocker commented 3 years ago

Thank you, I will take a look at ibantools.

tjcampbell commented 3 years ago

Careful pointing people to ibantools, it has a very restrictive license (MPL-2.0) compared to this package

Clindbergh commented 1 month ago

Careful pointing people to ibantools, it has a very restrictive license (MPL-2.0) compared to this package

ibantools can now be used under MIT too.

This work is dual-licensed under MIT and MPL-2.0. You can choose between one of them if you use this work. https://github.com/Simplify/ibantools/blob/16942b69e251304638559a73848b801365e0040e/README.md?plain=1#L111