search

arhs / spring-cache-mongodb

Spring Cache implementation based on MongoDB
MIT License
17 stars 14 forks source link

support for custom serializer #2

Open danomatic opened 7 years ago

danomatic commented 7 years ago

Allow applications to provide their own serializer, because the Java serializer can be problematic.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.5%) to 91.743% when pulling 9739d139bf5a00d5797c92f32531bf27bf11be40 on danomatic:custom-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.5%) to 91.743% when pulling 2a91f666202d6a1ff0a284528e66e5b1edeac2d2 on danomatic:custom-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.5%) to 91.743% when pulling b1bcb83c6e4f2ad429bb6826901650cf5ecc05a0 on danomatic:custom-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.6%) to 92.661% when pulling b1bcb83c6e4f2ad429bb6826901650cf5ecc05a0 on danomatic:custom-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

dnlprplt commented 7 years ago

@cyrilschumacher I agree this is a needed feature

danomatic commented 7 years ago

My company has been using this in production for months now. I just never got around to making a PR. Do you want more unit test coverage before this is merged?

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.5%) to 92.76% when pulling a1076979467365c7d75dbb9324fb06ee280c5f16 on danomatic:custom-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

danomatic commented 6 years ago

@danielprplt all the requested changes have been made

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.5%) to 92.76% when pulling ade7b6b5be07f4aa964842427171ebaaf5e7ba4c on danomatic:custom-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

Alir3z4 commented 6 years ago

This is really good. I'm working on a project and this specific pull requests is very helpful.

cyrilschumacher commented 6 years ago

@danomatic Could you improve the coverage (if possible)? @danielprplt What do you think?

cyrilschumacher commented 6 years ago

@danomatic Could you resolve the conflicts present in your branch? I merged your pull request. ;-)