search

arhs / spring-cache-mongodb

Spring Cache implementation based on MongoDB
MIT License
17 stars 14 forks source link

Hessian serializer #4

Open danomatic opened 7 years ago

danomatic commented 7 years ago

Based on the custom-serializer branch. Adds an additional serializer, HessianSerializer, that should be more performant and avoid some of the issues we experienced with JavaSerializer.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-11.3%) to 82.988% when pulling 213185449f2ed3db98a32c8cdf051b32d540c0f6 on danomatic:hessian-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-11.3%) to 82.988% when pulling bcabd3a4e0f7c182916ddf255b15e8d1158fab75 on danomatic:hessian-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-4.2%) to 90.041% when pulling bcabd3a4e0f7c182916ddf255b15e8d1158fab75 on danomatic:hessian-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-3.4%) to 90.871% when pulling ad425138ac27e9c0d7da4b71ecd72774bb13f3e2 on danomatic:hessian-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

danomatic commented 7 years ago

According to this, "The efficiency of Hessian 2.0 is about twice that of java.io serialization."

danomatic commented 7 years ago

My company has been using this in production for months without issue.

danomatic commented 7 years ago

That being said, this does add an extra Maven dependency. If that is problematic, it could be split to another project or we could just demonstrate how to use it in the docs.

dnlprplt commented 7 years ago

Ideally, we'd have to generate another jar with the serializer so that people could decide whether or not to include that dependency.

In the first place, I could live if we simply include the serializer in the main library.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-4.4%) to 89.837% when pulling d59bb4b82bb3ebf58ad1b3eee82e3885c7977f53 on danomatic:hessian-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

danomatic commented 7 years ago

@danielprplt I've added code to make sure that the input and output streams are closed.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-4.3%) to 89.96% when pulling 8d27dfb50df50e5257e289239ab989315c5c1be5 on danomatic:hessian-serializer into 99ea324daef9e9c65fddeb8a024f1dcd0c265199 on arhs:master.

cyrilschumacher commented 6 years ago

@danomatic Could you resolve the conflicts present in your branch? In any case, thank you for your work.