Closed arinban closed 9 years ago
arinban
commented
6 years ago arinban
commented
9 years ago @glassfishrobot Commented Reported by @carryel
arinban
commented
9 years ago @glassfishrobot Commented oleksiys said: looks good to me. Thank you!
[2.3.x] Revision: 3d1bdc8bc757840b244b89df936e69ccdb18e7b5 Date: 2014-11-11 04:45:31 UTC
[master] Revision: ff6db6c0a3befaa82855042a6128a79d4a4cadc9 Date: 2014-11-11 04:45:31 UTC
thanks to Bongjae
arinban
commented
9 years ago @glassfishrobot Commented File: Fixed_NPEs.patch Attached By: @carryel
arinban
commented
7 years ago @glassfishrobot Commented This issue was imported from java.net JIRA GRIZZLY-1716
arinban
commented
9 years ago @glassfishrobot Commented Marked as fixed on Monday, November 10th 2014, 8:49:43 pm
I met some NPEs during processing multiparts. Here are examples:
1. When there is no Content-Type header java.lang.NullPointerException at org.glassfish.grizzly.http.multipart.MultipartScanner.scan(MultipartScanner.java:85) at com.kakao.capri.api.server.handler.story.old.UploadHandler.beforeService(UploadHandler.java:98) at com.kakao.server.web.handler.GrizzlyHandler.service(GrizzlyHandler.java:127) at org.glassfish.grizzly.http.server.HttpHandler.runService(HttpHandler.java:201) at org.glassfish.grizzly.http.server.HttpHandler.doHandle(HttpHandler.java:175) at org.glassfish.grizzly.http.server.HttpHandlerChain.doHandle(HttpHandlerChain.java:223) at org.glassfish.grizzly.http.server.HttpServerFilter.handleRead(HttpServerFilter.java:235) at org.glassfish.grizzly.filterchain.ExecutorResolver$9.execute(ExecutorResolver.java:119) at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeFilter(DefaultFilterChain.java:284) at org.glassfish.grizzly.filterchain.DefaultFilterChain.executeChainPart(DefaultFilterChain.java:201) at org.glassfish.grizzly.filterchain.DefaultFilterChain.execute(DefaultFilterChain.java:133) at org.glassfish.grizzly.filterchain.DefaultFilterChain.process(DefaultFilterChain.java:112) at org.glassfish.grizzly.ProcessorExecutor.execute(ProcessorExecutor.java:77) at org.glassfish.grizzly.nio.transport.TCPNIOTransport.fireIOEvent(TCPNIOTransport.java:561) at org.glassfish.grizzly.strategies.AbstractIOStrategy.fireIOEvent(AbstractIOStrategy.java:112) at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.run0(WorkerThreadIOStrategy.java:117) at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy.access$100(WorkerThreadIOStrategy.java:56) at org.glassfish.grizzly.strategies.WorkerThreadIOStrategy$WorkerThreadRunnable.run(WorkerThreadIOStrategy.java:137) at com.kakao.common.util.StatisticKakaoThreadPoolExecutor$StatisticRunnable.run(StatisticKakaoThreadPoolExecutor.java:278) at com.kakao.common.util.KakaoThreadPoolExecutor$Worker.runTask(KakaoThreadPoolExecutor.java:950) at com.kakao.common.util.KakaoThreadPoolExecutor$Worker.run(KakaoThreadPoolExecutor.java:987) at java.lang.Thread.run(Thread.java:744)
2. When there is not http header key(field) java.lang.NullPointerException at java.lang.String$CaseInsensitiveComparator.compare(String.java:1176) at java.lang.String$CaseInsensitiveComparator.compare(String.java:1170) at java.util.TreeMap.put(TreeMap.java:545) at org.glassfish.grizzly.http.multipart.MultipartEntry.setHeader(MultipartEntry.java:220) at org.glassfish.grizzly.http.multipart.MultipartReadHandler.setHeader(MultipartReadHandler.java:387) at org.glassfish.grizzly.http.multipart.MultipartReadHandler.parseHeaders(MultipartReadHandler.java:338) at org.glassfish.grizzly.http.multipart.MultipartReadHandler.process(MultipartReadHandler.java:196) at org.glassfish.grizzly.http.multipart.MultipartReadHandler.onDataAvailable(MultipartReadHandler.java:128) at org.glassfish.grizzly.http.io.InputBuffer.notifyAvailable(InputBuffer.java:898) at org.glassfish.grizzly.http.io.InputBuffer.notifyAvailable(InputBuffer.java:855) at org.glassfish.grizzly.http.server.NIOInputStreamImpl.notifyAvailable(NIOInputStreamImpl.java:139)
I attached a simple patch.
@Alexey could you review it?