Merege Member Fails

[buffstop]

If you register with the same email address, make it a member in backend and use the "merge" with existing feature, an error occurs.

Repro:

• Register twice using the same email In Backend:
• click signature received, payment received
• click "make member" button In make member screen a warning is shown correctly and it asks you to merge both persons
• Click merge

Expected: Data is merged (sounds like a dangerous feature. We might want to deny registrations for existing emails in the first place).

Actual:

Internal Server Error

The server encountered an unexpected internal server error

(generated by waitress)

Log

2018-04-30 10:10:46,675 INFO [sqlalchemy.engine.base.Engine][Dummy-4] ROLLBACK 2018-04-30 10:10:46,675 DEBUG [txn.139970610185984][Dummy-4] abort 2018-04-30 10:10:46,676 ERROR [waitress][Dummy-4] Exception when serving /merge_member/63/28 Traceback (most recent call last): File "/home/coop-admin/.local/lib/python2.7/site-packages/waitress-0.8.9-py2.7.egg/waitress/channel.py", line 337, in service task.service() File "/home/coop-admin/.local/lib/python2.7/site-packages/waitress-0.8.9-py2.7.egg/waitress/task.py", line 173, in service self.execute() File "/home/coop-admin/.local/lib/python2.7/site-packages/waitress-0.8.9-py2.7.egg/waitress/task.py", line 392, in execute app_iter = self.channel.server.application(env, start_response) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid-1.5.2-py2.7.egg/pyramid/router.py", line 242, in call response = self.invoke_subrequest(request, use_tweens=True) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid-1.5.2-py2.7.egg/pyramid/router.py", line 217, in invoke_subrequest response = handle_request(request) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid_debugtoolbar-2.2.2-py2.7.egg/pyramid_debugtoolbar/toolbar.py", line 165, in toolbar_tween return handler(request) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid-1.5.2-py2.7.egg/pyramid/tweens.py", line 46, in excview_tween response = view_callable(exc, request) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid-1.5.2-py2.7.egg/pyramid/config/views.py", line 385, in viewresult_to_response result = view(context, request) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid-1.5.2-py2.7.egg/pyramid/tweens.py", line 21, in excview_tween response = handler(request) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid_tm-0.8-py2.7.egg/pyramid_tm/init.py", line 92, in tm_tween reraise(*exc_info) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid_tm-0.8-py2.7.egg/pyramid_tm/init.py", line 73, in tm_tween response = handler(request) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid-1.5.2-py2.7.egg/pyramid/router.py", line 163, in handle_request response = view_callable(context, request) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid-1.5.2-py2.7.egg/pyramid/config/views.py", line 245, in _secured_view return view(context, request) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid-1.5.2-py2.7.egg/pyramid/config/views.py", line 385, in viewresult_to_response result = view(context, request) File "/home/coop-admin/.local/lib/python2.7/site-packages/pyramid-1.5.2-py2.7.egg/pyramid/config/views.py", line 501, in _requestonly_view response = view(request) File "/home/coop-admin/PepCoopMembership/c3smembership/membership_list.py", line 299, in merge_member_view exceeds_max = int(orig.num_shares) + int(merg.num_shares) > c.max_shares NameError: global name 'c' is not defined

[ari-pep]

fixed by 8a9c86f