Backend: error shares/detail

[buffstop]

PRIO: not before opening gig

Repro: In backend:

• Go to membership list
• in collumn "shares" click "detail"

Expected: Some details in regards of the shares are shown.

Actual: Error is shown: Internal Server Error

The server encountered an unexpected internal server error

(generated by waitress)

###

self._render(*args, **kwargs) │····································································· File "/tmp/tmpQunSot/backend_3c11be5cd8f902046f5cde104dcea579.py", line 385, in render │····································································· slot_middle(__stream, econtext.copy(), rcontext) │····································································· File "/tmp/tmphJej5b/detail_d0f015b8b66c6a3c182f77a550fae4a7.py", line 19077, in fill_middle │····································································· __condition = (not (_lookup_attr(getitem('member'), 'membership_date') > date(2018, 11, 31)) and ((_lookup_attr(getitem('member'),│····································································· 'membership_loss_date') is None) or (_lookup_attr(getitem('member'), 'membership_loss_date') >= date(2018, 11, 1)))) │····································································· ValueError: day is out of range for month │····································································· │·····································································

• Expression: "request.static_url('c3smembership:static/c3s_b.css')" │·····································································
• Filename: ... min/PepCoopMembership/c3smembership/templates/backend.pt │·····································································
• Location: (line 15: col 18) │·····································································
• Source: ... ef="${request.static_url('c3smembership:static/c3s_b.css')}" │····································································· ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ │·····································································
• Expression: "backend" │·····································································
• Filename: ... dmin/PepCoopMembership/c3smembership/templates/detail.pt │·····································································
• Location: (line 5: col 23) │·····································································
• Source: metal:use-macro="backend"> │····································································· ^^^^^^^ │·····································································
• Arguments: version_location_url: <NoneType - at 0x55fe931094d0> │····································································· renderer_info: <RendererHelper - at 0x7fe9dbada950> │····································································· renderer_name: templates/detail.pt │····································································· message: │····································································· D: <type Decimal at 0x55fe94c13550> │····································································· version_location_name: <NoneType - at 0x55fe931094d0> │····································································· req: <RequestWithUserAttribute - at 0x7fe9dac27c90> │····································································· shares: <list - at 0x7fe9d8abf830> │····································································· member: <C3sMember - at 0x7fe9d8af7310> │····································································· backend: <PyramidPageTemplateFile - at 0x7fe9d8aca890> │····································································· macroname: backend │····································································· today: 2018-04-30 │····································································· repeat: {...} (0) │····································································· invoices18_07: <list - at 0x7fe9d8b06488> │····································································· invoices18_06: <list - at 0x7fe9d8af4ab8> │····································································· invoices18_05: <list - at 0x7fe9dac404d0> │····································································· invoices18_09: <list - at 0x7fe9d8b16560> │····································································· invoices18_08: <list - at 0x7fe9dacd87e8> │····································································· util: <module cornice.util at 0x7fe9dbe55248> │····································································· base: <PyramidPageTemplateFile - at 0x7fe9d8aca6d0> │····································································· base_bootstrap: <PyramidPageTemplateFile - at 0x7fe9d8aca750> │····································································· request: <RequestWithUserAttribute - at 0x7fe9dac27c90> │····································································· version_information: Version 1.20.4 │····································································· invoices18_12: <list - at 0x7fe9d8ab3f80> │····································································· context: <Root - at 0x7fe9dac4c350> │····································································· view: <function member_detail at 0x7fe9dbac7e60> │····································································· invoices18_10: <list - at 0x7fe9d8b16ef0> │····································································· invoices18_11: <list - at 0x7fe9d8b16518> │····································································· target_language: <NoneType - at 0x55fe931094d0>

[ari-pep]

fixed, but the new columns we added are not yet shown

[buffstop]

The issue persists here (in production I get the above mentione error, in test I get "Internal Server Error").

[ari-pep]

sorry, ment to write this on another issue :/

[ari-pep]

with current staging, this happens when one of the balance columns has NULL, which is the case for members added before the relevant db migration I think. Which is not the case for anyone in production.

this could be addressed when switching to generalized transactions

[buffstop]

Production is affected. Tested: myself: https://join.pep.coop/detail/5

[ari-pep]

the links work now, but the column is misleading: leads to membership detail, not the shares. This maybe was meant for /shares_detail/$id but the id indicates share package not member id. upstream has the same behaviour :/