search

aria-tools / ARIA-tools

Tools for exploiting ARIA standard products
Apache License 2.0
99 stars 36 forks source link

Add missing gdal libraries to the environment #445

Closed ehavazli closed 1 month ago

ehavazli commented 1 month ago

Add libgdal-hdf5 and libgdal-netcdf to the environment explicitly.

pep8speaks commented 1 month ago

Hello @ehavazli! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 74:80: E501 line too long (88 > 79 characters) Line 78:80: E501 line too long (85 > 79 characters) Line 81:80: E501 line too long (81 > 79 characters) Line 84:80: E501 line too long (85 > 79 characters) Line 130:80: E501 line too long (87 > 79 characters) Line 152:80: E501 line too long (82 > 79 characters) Line 243:80: E501 line too long (82 > 79 characters) Line 332:80: E501 line too long (83 > 79 characters)

alexfore commented 1 month ago

Hi @ehavazli -- I will approve this PR if it only contains those changes to environment.yml and requirements.txt files (it has an additional commit from your dev branch on it now). I've tested it on Oracle Linux 8 and my laptop.

ehavazli commented 1 month ago

Hi @alexfore , I dropped the last commit. Thanks for pointing it out.