ariacom / Seal-Report

Database Reporting Tool and Tasks (.Net)
https://sealreport.org
Other
1.43k stars 466 forks source link

Microsoft.AspNetCore.Razor.Language 2.2.0 -> 6.0.2 #72

Closed pacharbit closed 2 years ago

pacharbit commented 2 years ago

Hi, we are facing a DLL hell in our project, one of our dependency brings Microsoft.AspNetCore.Razor.Language 6.0.2, and SealReport brings Microsoft.AspNetCore.Razor.Language 2.2.0. Is it planned to update this component, or do you know a fork of SealReport that would implement Razor.Language 6.0.2 ? Thanks a lot Pierre

ariacom commented 2 years ago

I just made the move (Microsoft.AspNetCore.Razor.Language" Version="6.0.8"), if you get the last source code, you might validate the change... thanks.

pacharbit commented 2 years ago

Wow thanks so much for that ! we test the change and come back to you ;)

pacharbit commented 2 years ago

Hi, we are looking forward to integrate this Razor.Language version update in our developments to test it. Do you know when the next Seal Report build will be available? Thank you very much for your time, sorry for being in such a hurry, this issue is very blocking for us and we have to consider a plan B if we can't integrate your fix. Best regards Pierre

ariacom commented 2 years ago

Perhaps a 6.7 will come in October....

pacharbit commented 1 year ago

Thanks, that would be great ! have a nice day

pacharbit commented 1 year ago

Hi, thanks for this new version 6.7.0 ! We tried to integrate it in our project, but we faced some issues.

Do you know where this error comes from?

Thank you very much, have a nice day Pierre

ariacom commented 1 year ago

Hi, the dependencies of the RazorEngine project are: PackageReference Include="Microsoft.AspNetCore.Razor" Version="2.2.0" /> PackageReference Include="Microsoft.AspNetCore.Razor.Runtime" Version="2.2.0" /> PackageReference Include="Microsoft.AspNetCore.Razor.Language" Version="6.0.9" /> PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.1" /> PackageReference Include="System.Reflection.Emit" Version="4.7.0" /> PackageReference Include="Microsoft.CSharp" Version="4.7.0" />

The second error you mention appears when the Repository is not set (it cannot find the Model template in the Views directory). Check that the repository location is correct.

pacharbit commented 1 year ago

Hello, thanks for your answer, I checked the Seal Report package we get from nuget.org, it comes with RazorEngine >= 2.2.3.6. Visual Studio will take the v.2.2.4 just above, with RazorLanguage v.2.2.0.

2022-11-04_09h15_42

Our project that hosts Seal Report is a net6.0 one. Maybe we can force a dependency to RazorEngine 3 or above ?

ariacom commented 1 year ago

RazorEngine.NetCore is a local project compiled in the Seal solution. The version 2.2.3.6 is just in the project file, RootNamespace>RazorEngine AssemblyName>RazorEngine.NetCore PackageTags>RazorEngine;aspnetcore;NetCore Authors>Connie Yau, HermanHo, Fouad Messaia,Zuliang Liu(China) Description>Fork from https://github.com/hermanho/RazorEngine, But Fixed Bug that Razor string does not support @using and @inherits and @functions and @section, etc. RepositoryType>git Version>2.2.3.6 Copyright>RazorEngine Copyright © RazorEngine Project 2011-2018

the true dependencies are PackageReference Include="Microsoft.AspNetCore.Razor" Version="2.2.0" /> PackageReference Include="Microsoft.AspNetCore.Razor.Runtime" Version="2.2.0" /> PackageReference Include="Microsoft.AspNetCore.Razor.Language" Version="6.0.9" /> PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.1" /> PackageReference Include="System.Reflection.Emit" Version="4.7.0" /> PackageReference Include="Microsoft.CSharp" Version="4.7.0" />

if you have problems, you might consider to include the Seal Library in your project (it is open source)

ariacom commented 1 year ago

perhaps there is is mismatch during the nutget package generation, it wants to depends on RazorEngine.NetCore project... we will check in a future release if we can stick again to the original package.

pacharbit commented 1 year ago

Dear Ariacom, we are facing an issue with the last nuget package available on nuget.org. SealLibrary 6.7.2 needs RazorEngine 6.7.2, but this version doesn't exist on the nuget.org server. Can you push this nuget ? Thanks ! Pierre

ariacom commented 1 year ago

yes, the dependency is incorrect, we hope to fix this soon with the 6.8

pacharbit commented 1 year ago

Thanks

ariacom commented 1 year ago

hello, the 6.8 is published, and it comes with the RazorEngine package.

pacharbit commented 1 year ago

Thanks a lot, this will help ! Best regards Pierre