search

ariadne-cps / release-1.0

Frozen 1.0 release of the Ariadne C++ framework for cyber-physical systems
http://www.ariadne-cps.org
GNU General Public License v3.0
0 stars 0 forks source link

Review `Void Enclosure:: uniform_error_recondition()` #46

Closed lgeretti closed 7 years ago

lgeretti commented 7 years ago

Originally reported by Luca Geretti (Bitbucket: lgeretti, GitHub: lgeretti)

The implementation of uniform error reconditioning in geometry/enclosure.cc:1032 seems odd to me. I assume that it should work by collecting all the result indices for which a relatively large error is present in the model, then it modifies the models for those dimensions by creating a new parameter that encloses the error (which is then removed).

My doubts:

  1. The error_domains variable is assigned twice with no particular reason.
  2. The result dimensions chosen for moving the error into a new parameter do not match the dimensions for which the error is relatively large: we should apply the reconditioning to the large_error_indices[i] dimensions.
  3. The second error>MAXIMUM_ERROR seems redundant to me.
lgeretti commented 7 years ago

Original comment by Luca Geretti (Bitbucket: lgeretti, GitHub: lgeretti)

Applied to the 'ariadne' repository instead.