search

ariaieboy / filament-currency

Enhanced Currency Related stuff for Filament
MIT License
49 stars 8 forks source link

using money config to set DEFAULT_CURRENCY #18

Closed mohamad-supangat closed 7 months ago

mohamad-supangat commented 7 months ago

why use $currency = env('DEFAULT_CURRENCY', 'USD'); instead of using the default config from laravel money ?

ariaieboy commented 7 months ago

Thanks for your contribution Since this config value was added to laravel-money version >=5 We can't use it because we support laravel-money from v1-5 And also this change is not backward compatible.

the DEFAULT_CURRENCY environment value is used in laravel money 1-4 and they changed it to MONEY_DEFAULTS_CURRENCY.

ariaieboy commented 7 months ago

I've changed the code to use both env variables https://github.com/ariaieboy/filament-currency/pull/19