ariaieboy / filament-currency

Enhanced Currency Related stuff for Filament
MIT License
42 stars 8 forks source link

[Bug]: field is required on safari error #43

Closed ziming closed 6 days ago

ziming commented 6 days ago

What happened?

enter a form with this field say 18000 , press submit. it will say field is required. only happen on safari

How to reproduce the bug

enter a form with this field, press submit. it will say field is required. only happen on safari

I have downgraded all the way from 1.9.0 to 1.8.1 and it still happen on safari according to customers

Package Version

1.8.1 to 1.9.0

PHP Version

8.3

Laravel Version

11

Which operating systems does with happen with?

macOS

Notes

also happen on safari mobile according to site users

ariaieboy commented 6 days ago

create a repo that reproduces this bug so I can test it. It only shows an error on macOS Safari can you also test ios safari?

ziming commented 6 days ago

i don't have iPhone sorry

ariaieboy commented 6 days ago

I tested on ios safari and I couldn't reproduce this bug. You need to share a public repo with the minimum code required to reproduce this bug.

ziming commented 6 days ago

did u try a number big enough have auto comma like 18,000 ?

sample code

TextInput::make('amount')
                        ->label('Amount')
                        ->integer()
                        ->minValue(500)
                        ->maxValue(8_000_000_000)
                        ->currencyMask(precision: 0)
                        ->required(),
ziming commented 6 days ago

i don't have an iPhone so all i got is multiple different customers screenshots on safari

ariaieboy commented 6 days ago

@ziming test version 1.9.1 and let me know if this issue is fixed or not