arialdomartini / oh-my-git-themes

Themes of the ZSH version of oh-my-git prompt
27 stars 42 forks source link

oppa-lana-style - glyphs not found using "fallback" strategy #6

Closed njam closed 3 years ago

njam commented 7 years ago

In oppa-lana-style.zsh-theme the symbols are assigned hardcoded unicode character. For example "is_a_git_repo" is symbol number E20E:

: ${omg_is_a_git_repo_symbol:=''}

This is the correct position in the patched "awesome" font:

CODEPOINT_OF_AWESOME_GITHUB_ALT='e20e'

But when using the "fallback" strategy and thus the regular "awesome" font the position is F113:

CODEPOINT_OF_AWESOME_GITHUB_ALT='f113'

Wouldn't it be better to use the "font map" approach, and consider the environment variables like this? Then it would work for both cases.

omg_is_a_git_repo_symbol="\u${CODEPOINT_OF_AWESOME_GITHUB_ALT}"
omg_has_untracked_files_symbol="\u${CODEPOINT_OF_AWESOME_TINT}"
omg_has_adds_symbol="\u${CODEPOINT_OF_AWESOME_PLUS}"
omg_has_deletions_symbol="\u${CODEPOINT_OF_AWESOME_MINUS}"
omg_has_cached_deletions_symbol="\u${CODEPOINT_OF_OCTICONS_X}"
omg_has_modifications_symbol="\u${CODEPOINT_OF_OCTICONS_PENCIL}"
omg_has_cached_modifications_symbol="\u${CODEPOINT_OF_OCTICONS_FILE_TEXT}"
omg_ready_to_commit_symbol="\u${CODEPOINT_OF_AWESOME_SIGNIN}"
omg_is_on_a_tag_symbol="\u${CODEPOINT_OF_AWESOME_TAG}"
omg_needs_to_merge_symbol="\u1109"
omg_detached_symbol="\u${CODEPOINT_OF_AWESOME_UNLINK}"
omg_can_fast_forward_symbol="\u${CODEPOINT_OF_AWESOME_DOUBLE_ANGLE_UP}"
omg_has_diverged_symbol="\u${CODEPOINT_OF_OCTICONS_GIT_BRANCH}"
omg_not_tracked_branch_symbol="\u${CODEPOINT_OF_AWESOME_LAPTOP}"
omg_rebase_tracking_branch_symbol="\u${CODEPOINT_OF_OCTICONS_GIT_PULL_REQUEST}"
omg_merge_tracking_branch_symbol="\u${CODEPOINT_OF_OCTICONS_GIT_MERGE}"
omg_should_push_symbol="\u${CODEPOINT_OF_OCTICONS_CLOUD_UPLOAD}"
omg_has_stashes_symbol="\u${CODEPOINT_OF_AWESOME_STAR}"
omg_has_action_in_progress_symbol="\u${CODEPOINT_OF_AWESOME_WRENCH}"
njam commented 3 years ago

too old