arianne / stendhal

Stendhal is a fun friendly and free multiplayer online adventure game with an old school feel.
https://arianne-project.org
GNU General Public License v2.0
599 stars 201 forks source link

Some NPCs Don't Understand Normalized Chat Options #609

Closed AntumDeluge closed 10 months ago

AntumDeluge commented 11 months ago

🐞 Describe the bug

An example is Monogenes. When players as him for help one of the chat options parsed from his dialogue is "building". But he only responds to "buildings".

🔥 How to reproduce

Steps to reproduce the behavior:

  1. Speak to Monogenes.
  2. Say "help".
  3. Say "yes".
  4. Open the chat options dialog using the button labelled "Hi!" in the chat bar.
  5. Monogenes does not respond.

image

🛠️ Suggested fixes

I believe certain NPCs will need to be updated to respond to the singular counterparts of their chat options. So this is a server-side issue as far as I can tell.

AntumDeluge commented 11 months ago

Fixed Monogenes with 21c529a8fd8016a1a2ddac7dc96827bc109f1c85. But leaving open as we will likely come across more NPCs with the same issue.

AntumDeluge commented 10 months ago

Closing as other issues are listed in #640.