arianne / stendhal

Stendhal is a fun friendly and free multiplayer online adventure game with an old school feel.
https://arianne-project.org
GNU General Public License v2.0
599 stars 201 forks source link

Group Membership Not Recognized at Login #642

Closed AntumDeluge closed 9 months ago

AntumDeluge commented 10 months ago

🐞 Describe the bug

There are times at login when group membership is not recognized when not expired in the web client.

Video demonstrating issue: https://www.youtube.com/watch?v=DHKCCeLgYf8

It appears that the problem is that certain events are being received before the user instance is ready & therefore lost.

Related to #649

🔥 How to reproduce

Steps to reproduce the behavior:

  1. Join a group
  2. Exit client & reconnect immediately
  3. Check group status (may take multiple times reloading client)

🌍 Environment

🛠️ Suggested fixes

Cache any events received prematurely & execute after user instance is ready. It appears this is actually a server-side issue.

AntumDeluge commented 9 months ago

I'm stumped client-side. Java client doesn't seem to have this issue. I assumed because it updated the panel info when it is placed in the foreground. But I have looked at the code & I don't see anything where it does something differently than how the web client does it.