search

arianneorpilla / jidoujisho

A full-featured immersion language learning suite for mobile.
GNU General Public License v3.0
904 stars 58 forks source link

added subtitle font settings in subtitle option dialog and added a to… #279

Open SmartDevStar opened 1 year ago

SmartDevStar commented 1 year ago

added subtitle font settings in subtitle option dialog and added a toggle button to show media player bottom bar permanently.

arianneorpilla commented 1 year ago

Hi @SmartDevStar, thanks for your pull request. This project uses slang to generate and manage localisations, and you can access localised strings by using the t global variable.

Could I ask you to change your hardcoded strings to make use of new localised strings you can find in the localisation JSON file?

You can add values by editing that file and running flutter pub run slang.

Looks like I overlooked the edits to the localisation file. Thanks again and I'll test your branch sometime!

arianneorpilla commented 1 year ago

Hey @SmartDevStar. I've requested some changes on this pull request. Thanks for making it again -- I haven't tested and run it myself yet but I think I get the general idea of what you want to do. I think the new button you've made for pinning the menu needs to go elsewhere, however...

I'll test these changes myself. I know that this PR was made in relation to #276, so I don't mind if you made multiple PRs in progression for the following tasks, so you're not blocked in case you are ready to work on another PR while I am still approving things -- I'm actually quite busy to approve and unable to merge or make a new release for this feature ASAP but I am happy for you to lodge multiple PRs in the meantime and just compile the app for now with your own forked branch in the meantime while I haven't gotten to it yet.

Thanks again and really appreciate it.

SmartDevStar commented 1 year ago

Hey, Irorpilla. I don't also have much time. If you are not satisfied for UI, provide me exact UI so we don't waste time.

On Tue, Jul 18, 2023 at 7:34 AM lrorpilla @.***> wrote:

Hey @SmartDevStar https://github.com/SmartDevStar. I've requested some changes on this pull request. Thanks for making it again -- I haven't tested and run it myself yet but I think I get the general idea of what you want to do. I think the new button you've made for pinning the menu needs to go elsewhere, however...

I'll test these changes myself. I know that this PR was made in relation to #276 https://github.com/lrorpilla/jidoujisho/discussions/276, so I don't mind if you made multiple PRs in progression -- I'm actually quite busy to approve and make a new release for this feature ASAP but I am happy for you to lodge multiple PRs in the meantime and just compile the app for now with your own forked branch in the meantime while I haven't gotten to it yet.

Thanks again and really appreciate it.

— Reply to this email directly, view it on GitHub https://github.com/lrorpilla/jidoujisho/pull/279#issuecomment-1640240371, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6XQEN44ADMSLFMDDYDRXT3XQ2GG7ANCNFSM6AAAAAA2OKWVEI . You are receiving this because you were mentioned.Message ID: @.***>

arianneorpilla commented 1 year ago

Since we are both busy, you are welcome to leave your PR as is in the meantime. I will need to ensure this pull request meets certain standards and is in line with the rest of the project before merging, and part of that process is meeting me halfway with these requested changes.

SmartDevStar commented 1 year ago

Updated the request changes.

On Tue, Jul 18, 2023 at 8:21 AM lrorpilla @.***> wrote:

Since we are both busy, you are welcome to leave your PR as is in the meantime. I will need to ensure this pull request meets certain standards and part of that process is meeting me halfway with these requested changes.

— Reply to this email directly, view it on GitHub https://github.com/lrorpilla/jidoujisho/pull/279#issuecomment-1640324445, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6XQEN4HVLBUZRSW7KOGQO3XQ2LXLANCNFSM6AAAAAA2OKWVEI . You are receiving this because you were mentioned.Message ID: @.***>