arianneorpilla / jidoujisho

A full-featured immersion language learning suite for mobile.
GNU General Public License v3.0
904 stars 58 forks source link

Enhancement Idea #281

Closed brishtibheja closed 1 year ago

brishtibheja commented 1 year ago

I am totally aware how busy you are, so this is not me pestering you. But I just had a random thought which I thought I will put here for anyone who is interested(or if you get time again in はるか未来).

There are times when I encounter a sentence which is not enough context for a word(for instance 譲渡不可 from くまクマ). What you would usually do is manually select the sentence, which is hard on mobile(harder with 縦書き). So my idea was basically an enhancement in card browser which can select more sentence from either side of the text.

arianneorpilla commented 1 year ago

I don't think this is a feasible enhancement, it's honestly not that hard to select text in 縦書き, I suggest holding the start position and then dragging without letting go to your end position -- a single drag motion which is very easy to do as opposed to a single tap and adjust.

This enhancement would be hard to maintain for different media sources that exist, just for the edge case where manual selection is absolutely necessary. I feel this as a quality of life feature will see very little use for the high amount of effort, all so the user can avoid learning how to manually select better in the first place, which is better in the case you want to be specific about where to start and end something anyway.

I think I'm afraid I will have to turn this down unfortunately.

brishtibheja commented 1 year ago

@lrorpilla I am more focused on reading nowadays so it didn't come to my mind, but is manual selection from the subtitle possible with videos? I don't think we can do it yet. As for the enhancement, I think you are right that it will need very high amount of effort with very little benefit for the end user.