arianneorpilla / jidoujisho

A full-featured immersion language learning suite for mobile.
GNU General Public License v3.0
974 stars 62 forks source link

DSL dictionaries do not work in >2.8.8 #298

Open homocomputeris opened 1 year ago

homocomputeris commented 1 year ago

I tried to import some DSL dictionaries. However, they do not work. I thought it could be because of different encodings, but trying various combinations of encoding and line ending changed nothing. Target language is English.

Here are the examples of dictionaries that do not work: dsl.zip

Screenshots (tested both on 2.8.8 and 2.8.9) 1 2

homocomputeris commented 1 year ago

The dictionaries work in GoldenDict: 3

arianneorpilla commented 1 year ago

The English support of the application is unfortunately as is. This is something I plan to revisit once I am out of hiatus but not until then.

homocomputeris commented 1 year ago

How does DSL lookup depend on the language? I mean, DSL itself is just plain text.

arianneorpilla commented 1 year ago

The app is set up to have a different search algorithm for different languages. It's an open secret (if you can even call it that) that this app is primarily used and targeted to the Japanese learning community, so the English support has not seen as much love and interest from me. This is something I plan to address in the future, just not the immediate.

arianneorpilla commented 1 year ago

Not that it's out of malice or anything. That's just what I'm learning and that's what I have focused my attention, and what is in demand from my users when it comes to this app's development.

homocomputeris commented 1 year ago

I also checked with Japanese-English dictionaries with Japanese as target language in the settings. Unfortunately, doesn't work either.

dsl_jpn.zip

arianneorpilla commented 1 year ago

That is to be expected. I did not properly implement DSL import and it is a proof of concept at most and was done for a friend of mine. The application is as is at the moment and is primarily meant for use with Yomichan text dictionaries.

homocomputeris commented 1 year ago

Thanks for the explanation!

BilderLoong commented 1 year ago

I also tried importing a few DSL dictionaries include some Open DSL dictionaries from the 3. Getting Started, but none of them work; maybe add some reminders for users, so that they know there are some limitations of using a DSL dictionary