search

arianneorpilla / jidoujisho

A full-featured immersion language learning suite for mobile.
GNU General Public License v3.0
904 stars 58 forks source link

[Dictionary] Selection highlight does not match the text (due to the text enlarging on select) #320

Open ika-musuko opened 10 months ago

ika-musuko commented 10 months ago

First of all, thank you for creating a dictionary app that supports Yomichan dictionaries! Now I am able to have a streamlined app to use monolingual dictionaries on.

This issue is in the latest preview build.

The issue is that when you try to select text from the dictionary, the text enlarges, but the selection highlight does not. Meaning that the selection highlight is tracing the original text size as opposed to the enlarged text. This makes it hard to tell what is being selected. Screenshot_2023-10-28-21-20-03-83_d1e85489dfcf960faafc2f4d5db41573

Honestly I would like if there's an option not to have the text enlarge when the user tries to select it as well. The enlarging also seems to temporarily cut off the text being selected since it doesn't adjust the text wrapping to the enlarged font size.

arianneorpilla commented 10 months ago

I released 2.9.0 as in beta precisely because of issues like this -- thanks for reporting. I'll figure this out at some point.

ika-musuko commented 10 months ago

Thanks for the reply! I just downloaded 2.8.9 and don't have this highlighting issue there so I will just stick with that version until 2.9.x becomes stable.

ika-musuko commented 1 month ago

Reporting that this is not an issue in 2.9.0-preview2. Thanks for fixing!