search

arianneorpilla / jidoujisho

A full-featured immersion language learning suite for mobile.
GNU General Public License v3.0
819 stars 55 forks source link

Dictionary lookup broken for certain epub(s) #333

Open Cephian opened 7 months ago

Cephian commented 7 months ago

Yomichan lookups in ttu reader from this book work just fine on my laptop, so I believe this is a jidoujisho issue. The book renders fine. Lookups for titles and index sections work, but not lookups within the main text sections.

I believe this is related to the fact that the text in each longer section from this book is given in one gigantic <span> section separated by <br/> tags for each line, and not by breaking into smaller <p> sections for each line like most other epubs. When I edit the epub, manually breaking the text in the XML within the epub into sections using <p> tags, lookups work.

Here is the book in question, I hope the keisatsu don't find me: https://drive.google.com/file/d/16x3O4HpCaCcGfBqyLaci5-_syzWOLGgh/view?usp=sharing

brishtibheja commented 5 months ago

This has happened to me before! btw just in case you didn't know the dev is on a hiatus for now. So either someone contributes to the code or we wait until he returns one day.